Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIGTOP-4232. Drop Ubuntu-18.04 #1297

Merged
merged 1 commit into from
Sep 24, 2024
Merged

Conversation

masatana
Copy link
Contributor

@masatana masatana commented Sep 21, 2024

Description of PR

Ubuntu 18.04 has been already EOL. We can just drop it.

How was this patch tested?

$ ./gradlew bigtop-puppet -POS=ubuntu-18.04 -Pprefix=3.3.0 bigtop-puppet
(..snip...)
Dockerfile:5                                                                                                            --------------------                                                                                                       3 |     COPY puppetize.sh /tmp/puppetize.sh                                                                             4 |                                                                                                                     5 | >>> RUN bash /tmp/puppetize.sh
   6 |
--------------------
ERROR: failed to solve: process "/bin/sh -c bash /tmp/puppetize.sh" did not complete successfully: exit code: 1         
> Task :bigtop-puppet FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':bigtop-puppet'.
> Process 'command './build.sh'' finished with non-zero exit value 1

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

* Get more help at https://help.gradle.org                                                                              
BUILD FAILED in 13s
1 actionable task: 1 executed

Failed as expected.

For code changes:

  • Does the title or this PR starts with the corresponding JIRA issue id (e.g. 'BIGTOP-3638. Your PR title ...')?
  • Make sure that newly added files do not have any licensing issues. When in doubt refer to https://www.apache.org/licenses/

Copy link
Member

@iwasakims iwasakims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @masatana.

@iwasakims iwasakims merged commit 551b6a1 into apache:master Sep 24, 2024
@masatana masatana deleted the BIGTOP-4232 branch September 24, 2024 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants